[U-Boot] [PATCH V2] Fix FIT and fdt blob support to have CONFIG_OF_LIBFDT and CONFIG_FIT independant

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1227218344-6911-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> FDT support is used for both FIT style images and architectures (ppc, m68k, sparc)
> that can pass a fdt blob to an OS..
> 
> For other arch and board which do not pass a fdt blob to an OS but want to use
> the new uImage format, we just need FIT support (ex : ARM).
> 
> Now we can have the 4 following configurations :
> 
> 1) FIT only		CONFIG_FIT
> 2) fdt blob only	CONFIG_OF_LIBFDT
> 3) both			CONFIG_OF_LIBFDT & CONFIG_FIT
> 4) none			none
> 
> And remove arch macro ifdef and use 2 new config for the functionnality to enable
> 
> so we introduce these :
> 	CONFIG_BOOT_INIT_RAMDISK
> 
> 	Define this if you want support for relocating init ramdisk
> 
> 	CONFIG_BOOT_INIT_RAMDISK
> 
> 	Define this if you want support for allocate and initialize kernel
> 	information for booting
> 
> and create a new arch default config where these new are manage for ppc, m68k,
> sparc actually via include/configs/{arch}/default.h

I reject this patch. It does not solve any problem, instead it only
obfuscates the code.

The starting point of this discussion was that we wanted to  get  rid
of  architecture  specific  #defines  like "#if defined(PPC)" and use
feature-specific defines instead. Now you create  such  new  defines,
and  move  them to architecture specific files, i. e. we leave every-
thing as is (architecture dependent), just much more complicated  and
information distributed over tens of files.

I cannot accept this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de