[U-Boot] [PATCH-OMAP3] OMAP3: Convert readl/writel and replace hardcoded values

Wolfgang Denk wd at denx.de
Mon Nov 24 00:47:39 CET 2008

Dear Graeme,

In message <d66caabb0811231536k455da2e6wc0ce1a774d37e4 at mail.gmail.com> you wrote:
> > The only clean and portable and thus reliable way is to use the (CPU
> > specific) accessor macros or functions.
> Will do :)


> It seems to me that more and more of these 'style' issues are
> cropping up. Should there be a document that covers them so we can
> start to systematically improve the consistency of the code?

Well, there is: http://www.denx.de/wiki/U-Boot/CodingStyle and

The thing is, that only now people start to realize the importance of
some of these issues. The PowerPC tree may be well ahead compared  to
other  architectures,  because that's where both big fat 64bit server
machines on one side and low-end (50 MHz) embedded processors on  the
other  side  have  been  supported  for a long time. I think no other
architecture does that in a  similar  way.  [x86  may  be  different,
because it always is.]

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We do not colonize. We conquer. We rule. There is no  other  way  for
	-- Rojan, "By Any Other Name", stardate 4657.5

More information about the U-Boot mailing list