[U-Boot] [PATCH 2/4] FDT: Enable microblaze cpu in image.c

[Wolfgang Denk]

Dear Michal,

In message <3ef2f793487258a2c06115525afc08e63dd3a222.1227524159.git.monstr at monstr.eu> you wrote:
> From: Michal Simek <monstr at monstr.eu>
> 
> 
> Signed-off-by: Michal Simek <monstr at monstr.eu>
> ---
>  common/image.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/common/image.c b/common/image.c
> index 866edf6..1459024 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -982,7 +982,8 @@ int boot_get_ramdisk (int argc, char *argv[], bootm_headers_t *images,
>  	return 0;
>  }
>  
> -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
> +#if defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || defined(CONFIG_PPC) \
> + || defined(CONFIG_SPARC)
>  /**
>   * boot_ramdisk_high - relocate init ramdisk
>   * @lmb: pointer to lmb handle, will be used for memory mgmt

I reject this patch.

I know this is not your fault - you just add to existing code. But the
existing code is wrong, and we should not add even more bad code (and
rather fix the current, incorrect one).

The thing is that the code  we  are  #ifdef'ing  here  depends  on  a
*feature*  (FDT  boot  support),  and thus can be selected on a board
level. It is *not* an architecture  thing,  so  it  is  incorrect  to
enable or disable it depending on the current arch settings.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is a drug. Too much of it kills you.
                                      - Terry Pratchett, _Small Gods_