[U-Boot] [PATCH 2/4] FDT: Enable microblaze cpu in image.c

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Nov 24 14:02:14 CET 2008


On 13:57 Mon 24 Nov     , Michal Simek wrote:
> Hi Wolfgang,
> 
> > Dear Michal,
> > 
> >>  
> >> -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
> >> +#if defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || defined(CONFIG_PPC) \
> >> + || defined(CONFIG_SPARC)
> >>  /**
> >>   * boot_ramdisk_high - relocate init ramdisk
> >>   * @lmb: pointer to lmb handle, will be used for memory mgmt
> > 
> > I reject this patch.
> > 
> > I know this is not your fault - you just add to existing code. But the
> > existing code is wrong, and we should not add even more bad code (and
> > rather fix the current, incorrect one).
> > 
> > The thing is that the code  we  are  #ifdef'ing  here  depends  on  a
> > *feature*  (FDT  boot  support),  and thus can be selected on a board
> > level. It is *not* an architecture  thing,  so  it  is  incorrect  to
> > enable or disable it depending on the current arch settings.
> 
> I understand.
> When will be remove this part of code?
> Because without any fix all Microblaze boards can't be successfully compiled.
> 
try my patch

 [PATCH V3] Fix FIT and fdt blob support to have CONFIG_OF_LIBFDT and
 CONFIG_FIT independant

Best Regards,
J.


More information about the U-Boot mailing list