[U-Boot] [RFC PATCH] USB style patch

Wolfgang Denk wd at denx.de
Wed Nov 26 13:07:09 CET 2008


Dear michael,

In message <492D31AC.2070006 at gandalf.sssup.it> you wrote:
> 
> >> -               printf("  NOTE: this command is obsolete and will be phased out\n");
> >> -               printf("  please use 'usb storage' for USB storage devices information\n\n");
> >> +               printf("  NOTE: this command is obsolete and will be"
> >> +                       " phased out\n");
> >> +               printf("  please use 'usb storage' for USB storage devices"
> >> +                       " information\n\n");
> >>     
> >
> > I believe it is good to keep line lengths below 80 characters in
> > general, but code should not become less readable by this.
> > In case of printf lines, it becomes more difficult to 'grep' for the
> > strings printed in the terminal to find them back in the code.
> > So, I am very curious about the point of view Wolfgang about this
> > rule. (How strict does this rule need to be applied?)
> >   
> I prefer to break the line but I wait for Walfgang answer.

I tend to go with Remy here, but tyher eis another (even better)
option: do what the warning says, and remove the obsolete code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The nice thing about  standards  is that there are  so many to choose
from.                                           - Andrew S. Tanenbaum


More information about the U-Boot mailing list