[U-Boot] [PATCH] ads5121: support for running from memory

[Wolfgang Denk]

Dear "Nikita V. Youshchenko",

In message <200810030003.53046 at blacky.localdomain> you wrote:
>
>     ads5121: support for running from memory

Ummm... (NOR) flash is memory, too. I guess you mean explicitely
running from RAM, don't you? Then please write what you mean.

>     - helps u-boot to find it's environment in flash when CFG_MONITOR_BASE does
>       not point to u-boot flash address.

Helps to find? You are hard-wiring the value, don't you? So not much
needs to be found ... ?

> @@ -322,7 +322,12 @@
>   */
>  #define CONFIG_ENV_IS_IN_FLASH	1
>  /* This has to be a multiple of the Flash sector size */
> +#if CFG_MONITOR_BASE >= CFG_FLASH_BASE
>  #define CONFIG_ENV_ADDR		(CFG_MONITOR_BASE + CFG_MONITOR_LEN)
> +#else
> +#define CFG_MONITOR_FLASH_BASE	0xfff00000
> +#define CONFIG_ENV_ADDR		(CFG_MONITOR_FLASH_BASE + CFG_MONITOR_LEN)
> +#endif
>  #define CONFIG_ENV_SIZE		0x2000
>  #ifdef CONFIG_BKUP_FLASH
>  #define CONFIG_ENV_SECT_SIZE	0x20000	/* one sector (256K) for env */

Hm ... you use CFG_MONITOR_FLASH_BASE just a single time, to set
CONFIG_ENV_ADDR. Why don't you set CONFIG_ENV_ADDR directly?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To understand a program you must become  both  the  machine  and  the
program.