[U-Boot] [PATCH 03/12 v2] ARM: OMAP3: Add overo pin mux, omap3 and prototype headers

Dirk Behme dirk.behme at googlemail.com
Sun Oct 5 08:56:43 CEST 2008


Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:38 Fri 03 Oct     , dirk.behme at googlemail.com wrote:
> 
>>Subject: [PATCH 03/12 v2] ARM: OMAP3: Add overo pin mux, omap3 and prototype headers
>>
>>From: Dirk Behme <dirk.behme at gmail.com>
>>
>>Add overo pin mux, omap3 and prototype headers
>>
>>Signed-off-by: Dirk Behme <dirk.behme at gmail.com>
>>
>>---
>>Changes in version v2:
>>
>>- Update Overo pin mux to add and pull down X_GATE, by Steve Sakoman.
>>
>> include/asm-arm/arch-omap3/mux.h       |  337 +++++++++++++++++++++++++++++++++
>> include/asm-arm/arch-omap3/omap3.h     |  135 +++++++++++++
>> include/asm-arm/arch-omap3/sys_proto.h |   71 ++++++
>> 3 files changed, 543 insertions(+)
>>
>>Index: u-boot-arm/include/asm-arm/arch-omap3/mux.h
>>===================================================================
>>--- u-boot-arm.orig/include/asm-arm/arch-omap3/mux.h
>>+++ u-boot-arm/include/asm-arm/arch-omap3/mux.h
>>@@ -754,4 +754,341 @@
>> 	MUX_VAL(CP(sdrc_cke0),      (IDIS | PTU | EN  | M0)) /*sdrc_cke0*/\
> 
> Same as before
> please use tab instead of space

Thanks for review. Will do so (for 02/12, too).

> and please be carefull of 80 chards limit

Do you mean now or after replacing spaces with tabs?

I carefully checked and think that at the moment (so the space 
version) has everything < 80 chars. If not, please let me know where 
you found violation.

Well, with tab instead of space most probably it will become hard to 
stay < 80 chars. But I will see what I can do.

Thanks for looking at it,

Dirk

P.S.: When we fix space/tab and the nand issue, will you apply this 
patchset to u-boot-arm next, then?



More information about the U-Boot mailing list