[U-Boot] [PATCH] Red Black Tree support

Wolfgang Denk wd at denx.de
Mon Oct 6 09:26:29 CEST 2008


Dear Kyungmin Park,

In message <20081006014744.GA5438 at july> you wrote:
> RB-tree support on U-Boot 
> Now it's used at UBI module. Of course other modules can use it.
...

I understand the code is a verbatim copy from the LInux kernel?
Otherwise the coding style violations would not be acceptable.

> diff --git a/lib_generic/Makefile b/lib_generic/Makefile
> index 7df5a2c..83b41ca 100644
> --- a/lib_generic/Makefile
> +++ b/lib_generic/Makefile
> @@ -45,6 +45,7 @@ COBJS-y += string.o
>  COBJS-y	+= strmhz.o
>  COBJS-y += vsprintf.o
>  COBJS-y += zlib.o
> +COBJS-y += rbtree.o

I expect that only few systems will actually use this, so it must be
configurable. It makes no sense to build this for ALL systems. Please
add a config option.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Reader, suppose you were an idiot. And suppose you were a  member  of
Congress. But I repeat myself.                           - Mark Twain


More information about the U-Boot mailing list