[U-Boot] [PATCH] Olimex SAM9-L9260 board support

[Wolfgang Denk]

Dear Cristian Birsan,

> +#ifdef CONFIG_RESET_PHY_R
> +void reset_phy(void)
> +{
> +#ifdef CONFIG_MACB
> +	/*
> +	 * Initialize ethernet HW addr prior to starting Linux,
> +	 * needed for nfsroot
> +	 */
> +	eth_init(gd->bd);
> +#endif

Please do NOT  do  this.  It's  a  violation  of  the  U-Boot  design
principles,  which  clearly  say that only such periphereals that are
actually being used by U-Boot shall be initialized, and even if  they
are being used, these shall be deactivated after use.

Carelessly leaving ports or devices in an initialized stated has been
the source for problems too many times before.

Don't do that.

> +#define ROUND(A, B)		(((A) + (B)) & ~((B) - 1))

First I think that this is wrong (maybe you need "B-1" instead of "B"
in the first part?), second we already have DIV_ROUND_UP  defined  in
common.h so please use this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A well-written program is its own heaven; a poorly-written program is
its own hell.             -- Geoffrey James, "The Tao of Programming"