[U-Boot] [PATCH 1/3 v2] ppc4xx: Add AMCC Arches boardsupport(dual 460GT)

[Victor Gallardo]

Dear Wolfgang,

> > diff --git a/include/configs/canyonlands.h 
> > b/include/configs/canyonlands.h index 2f162e1..acad9b3 100644
> > --- a/include/configs/canyonlands.h
> > +++ b/include/configs/canyonlands.h
> ...
> > +#define CONFIG_PREBOOT \
> > +	"setenv ethact ppc_4xx_eth1;" \
> 
> This should not be done in the preboot command, but as part of the 
> default config instead.

I reviewed this again. It cannot be part of default config. We need
to do it at PREBOOT because eth_register() updates this variable
each time at boot. It assigns ethact to the first ethernet port it
discovers. In Arches, we need the second Ethernet port set as ethact.
Updating it at preboot allows us to update after eth_register has
set it.

Best Regards,

Victor Gallardo