[U-Boot] [PATCH 2/4] ppc4xx: Fix DU440 GPIO configuration

[Matthias Fuchs]

Hi Stefan,

I am aware of the CFG_4xx_GPIO_TABLE feature. I think there is also 
a TODO comment for this in my code. But right now I want to keep it as it is
because of a lack of time.

Matthias

On Wednesday 08 October 2008 11:50, Stefan Roese wrote:
> Hi Matthias,
> 
> On Tuesday 07 October 2008, matthias.fuchs at esd-electronics.com wrote:
> > From: Matthias Fuchs <matthias.fuchs at esd-electronics.com>
> >
> > Signed-off-by: Matthias Fuchs <matthias.fuchs at esd-electronics.com>
> > ---
> >  board/esd/du440/du440.c |   10 +++++-----
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/board/esd/du440/du440.c b/board/esd/du440/du440.c
> > index 8765cc1..5cff9f5 100644
> > --- a/board/esd/du440/du440.c
> > +++ b/board/esd/du440/du440.c
> > @@ -52,15 +52,15 @@ int board_early_init_f(void)
> >  	 * Setup the GPIO pins
> >  	 */
> >  	out_be32((void*)GPIO0_OR, 0x00000000 | CFG_GPIO0_EP_EEP);
> > -	out_be32((void*)GPIO0_TCR, 0x0000000f | CFG_GPIO0_EP_EEP);
> > +	out_be32((void*)GPIO0_TCR, 0x0000001f | CFG_GPIO0_EP_EEP);
> 
> You might want to switch to the 4xx-GPIO initialization via the 
> CFG_4xx_GPIO_TABLE define at some time. This makes it much easier to 
> configure the GPIO's correctly.
> 
> But if you don't want to do this right now, I can apply this current patch for 
> now as a bug fix.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> 
> 

-- 
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Geschäftsführer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------