[U-Boot] [patch 1/2] fix USB initialisation procedure

Wolfgang Denk wd at denx.de
Thu Oct 9 15:19:22 CEST 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081009121044.GA25278 at game.jcrosoft.org> you wrote:
>
> >  	if (dev->status == 0)
> >  		return dev->act_len;
> please add {} to if too or remove the else
> > -	else
> > +	else {
> > +		/* Let's wait a while for the timeout to elaps.
> > +		 * it has no real use, but it keeps the interface happy. */
> > +		wait_ms(timeout);
> >  		return -1;
> > +	}

Good catch.

Actually the "else" should be removed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the strict scientific sense we all feed on death -- even
vegetarians.
	-- Spock, "Wolf in the Fold", stardate 3615.4


More information about the U-Boot mailing list