[U-Boot] [PATCH] Align end of bss by 4 bytes.

Dan Malek dan at embeddedalley.com
Wed Oct 15 22:54:44 CEST 2008


On Oct 15, 2008, at 1:17 PM, Selvamuthukumar wrote:

> Most of the bss initialization loop increments 4 bytes
> at a time. And the loop end is checked for an 'equal'
> condition. Make the bss end address aligned by 4, so
> that the loop will end as expected.

IMHO, this is a bad programming practice to check
for equal and make these assumptions.  The code should
be corrected to determine the proper size of the bss
space and zero accordingly.... or at least test for
greater than or equal.

Thanks.

	-- Dan



More information about the U-Boot mailing list