[U-Boot] [PATCH 2/2][for v2008.10] 85xx: Using proper I2C source clock divider for MPC8544

[Jerry Van Baren]

Timur Tabi wrote:
> Kumar Gala wrote:
> 
>>> How about adding a comment that the RM is wrong?   Any time the code
>>> disagrees with the RM, it *has* to be documented.
>> Its documented in the commit.
> 
> Sorry, but that's just not good enough for me.  I *hate* it when people say that
> it is.
> 
> When I'm looking at some code, and I don't understand what it does, the last
> thing I'm doing to do is scour through the git log trying to find some
> explanation.
> 
> Would it really have been so hard to add this line?
> 
> /* The MPC8544 RM says it's bit 26, but it's really bit 28 */

I have to agree with Timur, we *need* a comment in the source code for 
future reference.  The git log is good, but not sufficient.

Thanks,
gvb