[U-Boot] [PATCH 2/2][for v2008.10] 85xx: Using proper I2C source clock divider for MPC8544

Kumar Gala galak at kernel.crashing.org
Mon Oct 20 22:06:08 CEST 2008


On Oct 20, 2008, at 2:22 PM, Wolfgang Denk wrote:

> Dear Jerry Van Baren,
>
> In message <48FC815A.90501 at ge.com> you wrote:
>>
>>> Would it really have been so hard to add this line?
>>>
>>> /* The MPC8544 RM says it's bit 26, but it's really bit 28 */
>>
>> I have to agree with Timur, we *need* a comment in the source code  
>> for
>> future reference.  The git log is good, but not sufficient.
>
> Agreed, but in the first place we should figure out if it's  *really*
> bit 28 (then the new code is wrong), or bit 24, then the doc is wrong
> again.

Its bit 24, my commit message was incorrect.

- k


More information about the U-Boot mailing list