[U-Boot] [PATCH] pci: Allow for PCI addresses to be 64-bit
Wolfgang Denk
wd at denx.de
Tue Oct 21 21:12:17 CEST 2008
Dear Kumar Gala,
In message <1224607998-22663-1-git-send-email-galak at kernel.crashing.org> you wrote:
> PCI bus is inherently 64-bit. While not all system require access to
> the full 64-bit PCI address range some do. This allows those systems
> to enable the full PCI address width via CONFIG_PCI_64BIT.
>
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
Mostly an ACK, except one tiny detail...
> --- a/include/pci.h
> +++ b/include/pci.h
> @@ -312,13 +312,21 @@
>
> #include <pci_ids.h>
>
> +#ifdef CONFIG_PCI_64BIT
I think we should make this "CONFIG_SYS_PCI_64BIT" instead.
This is really a low-level config option where the end user is not
supposed to mess with.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
THIS IS A 100% MATTER PRODUCT: In the Unlikely Event That This
Merchandise Should Contact Antimatter in Any Form, a Catastrophic
Explosion Will Result.
More information about the U-Boot
mailing list