[U-Boot] [PATCH] [ONENAND] Reduce OneNAND IPL code size

Wolfgang Denk wd at denx.de
Thu Oct 23 11:13:16 CEST 2008


Dear "Kyungmin Park",

In message <9c9fda240810230139h19724311l2aa987780335c064 at mail.gmail.com> you wrote:
> On Thu, Oct 23, 2008 at 5:09 PM, Wolfgang Denk <wd at denx.de> wrote:
> > Dear Kyungmin Park,
> >
> > In message <20081023005452.GA13453 at july> you wrote:
> >> To give more code at lowlevel_init at each boards
> >
> > Can you please describe exactly what thgis patch is supposed to do and
> > what problem it is supposed to fix?
> >
> > I cannot make heads nor tails from your descritpion, sorry.
> 
> OneNAND IPL has common codes for RAM init, load data, and jump to 2nd
> bootloader, but it's common code used about 300~400 bytes. So board
> specific codes, such as lowlevel_init, can't has enough code. It make
> a difficult to implement OneNAND IPL.
> 
> This patch make this common code as small as possible. and give
> lowlevel_init can have more codes.

Please add this explanation to the commit message, then. Otherwise it
is not possible to understand the rationale for the change.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No man knows what true happiness is until he gets married.  By  then,
of course, its too late.


More information about the U-Boot mailing list