[U-Boot] [PATCH 3/3] XPedite5370 board support

[Andy Fleming]

On Thu, Oct 23, 2008 at 5:23 PM, Peter Tyser <ptyser at xes-inc.com> wrote:
> Initial support for Extreme Engineering Solutions XPedite5370 -
> a MPC8572-based 3U VPX single board computer with a PMC/XMC
> site.
>
> Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> ---
>  MAINTAINERS                         |    3 +
>  MAKEALL                             |    1 +
>  Makefile                            |    3 +
>  board/xes/common/Makefile           |   56 ++++
>  board/xes/common/fsl_8572_clk.c     |   51 +++
>  board/xes/common/fsl_85xx_ddr.c     |   93 ++++++
>  board/xes/common/fsl_85xx_pci.c     |  287 +++++++++++++++++


Could you take a look at the new PCI code Kumar submitted (which I
just applied), and rework the board code to imitate that code (it
should be a trivial change, but one that makes things cleaner)



> +int board_early_init_r(void)
> +{
> +       const unsigned int flashbase = CONFIG_SYS_FLASH_BASE2;
> +       int i;
> +
> +       /* Initialize PCA9557 devices */
> +       pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
> +       pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR1, 0xff, 0);
> +       pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
> +       pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
> +
> +       /* Invalidate flash region */
> +       for (i = 0; i < 256 * 1024 * 1024; i += 32) {
> +               asm volatile ("dcbi %0,%1": : "b" (flashbase), "r" (i));
> +               asm volatile ("icbi %0,%1": : "b" (flashbase), "r" (i));
> +       }


Take a look at the current 8572DS code for doing this.  By mapping
things correctly, you can use dcbf, and not have to go through the
entire memory space of your flash.

Otherwise, it looks good to me.

Andy