[U-Boot] [PATCH] at91: board specific lowlevel_init.S

[Wolfgang Denk]

Dear Ilko,

In message <4905FE17.4040001 at ronetix.at> you wrote:
> 
> > On 09:27 Mon 27 Oct     , Ben Warren wrote:
...
> >> I've found that weak functions are only overwritten if the overwriting
> >> function is in a file (not archive) that has strongly-linked symbols.
> >> Admittedly, I've only done this with C code but expect that the assembly
> >> equivalent works the same way.  The idea of using weak functions seems
> >> great, but suffers from some pretty cumbersome weaknesses :)
...
>
> Could be possible to commit my patch (I need it for the PM9261/PM9263

I don't think this makes sense. If Ben is right (and  I  don't  doubt
that),  than  all  that  needs  to  be  done  is  to  link  your own,
board-specific lowlevel_init.o file separately, i. e. not as part  of
the lib$(BOARD).a archive.

This seems to be easy to do.

> patches) because the moving from AR to LD will take a lot of time.
> When the moving from AR to LD is done, I will correct my board's patches.

Argh. May we please try and get the terms  right.  I  know  that  you
didn't  phrase  the words "moving from AR to LD", but repeating these
makes no sense either. We've been using the  linker  ("ld")  all  the
time and will continue to use it, no matter if we're liking libraries
or object files. And note that we already now use a mix of both.

> Otherwise I must wait a lot of time and must change my patches every
> time when there is an correction in the at91 platform.

Right. So let's do it right now. Please use the weak approach as
described.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I think trash is the most important manifestation of culture we have
in my lifetime."                                      - Johnny Legend