[U-Boot] [PATCH 1/7] sh: ap325rxa: Moveed ap325rxa board in board/renesas

Peter Tyser ptyser at xes-inc.com
Tue Oct 28 15:36:10 CET 2008


Hi Nobuhiro,
The titles for this patch series should be renamed with s/Moveed/Moved/
and maybe s/in/to/.

Also, git should be smart enough to know the files were moved as opposed
to separate file deletions/creations.  For example from "[PATCH 01/12]
gunzip: move to lib_generic":

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
---
 common/Makefile                  |    1 -
 lib_generic/Makefile             |    1 +
 {common => lib_generic}/gunzip.c |    0 
 3 files changed, 1 insertions(+), 1 deletions(-)
 rename {common => lib_generic}/gunzip.c (100%)

diff --git a/common/Makefile b/common/Makefile
index 944b1c0..d974823 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -36,7 +36,6 @@ COBJS-$(CONFIG_CMD_BDI) += cmd_bdinfo.o
 COBJS-$(CONFIG_CMD_BEDBUG) += cmd_bedbug.o
 COBJS-$(CONFIG_CMD_BMP) += cmd_bmp.o
 COBJS-y += image.o
-COBJS-y += gunzip.o
 COBJS-y += cmd_boot.o
 COBJS-$(CONFIG_CMD_BOOTLDR) += cmd_bootldr.o
 COBJS-y += cmd_bootm.o
diff --git a/lib_generic/Makefile b/lib_generic/Makefile
index bf0e31d..a820f97 100644
--- a/lib_generic/Makefile
+++ b/lib_generic/Makefile
@@ -34,6 +34,7 @@ COBJS-y += crc32.o
 COBJS-y += ctype.o
 COBJS-y += display_options.o
 COBJS-y += div64.o
+COBJS-y += gunzip.o
 COBJS-y += lmb.o
 COBJS-y += ldiv.o
 COBJS-$(CONFIG_MD5) += md5.o
diff --git a/common/gunzip.c b/lib_generic/gunzip.c
similarity index 100%
rename from common/gunzip.c
rename to lib_generic/gunzip.c


Maybe you have to explicitly use the "git mv" command, I'm not sure...
Without git noticing the files were only moved I'm doubtful the moved
files would retain their history log and only having the relevant file
changes in the diff would clean up the patches significantly.

Best,
Peter

On Tue, 2008-10-28 at 22:54 +0900, Nobuhiro Iwamatsu wrote:
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
> ---
>  Makefile                               |    2 +-
>  board/ap325rxa/Makefile                |   51 -------
>  board/ap325rxa/ap325rxa.c              |  162 ---------------------
>  board/ap325rxa/config.mk               |   26 ----
>  board/ap325rxa/cpld-ap325rxa.c         |  206 ---------------------------
>  board/ap325rxa/lowlevel_init.S         |  243 --------------------------------
>  board/ap325rxa/u-boot.lds              |  105 --------------
>  board/renesas/ap325rxa/Makefile        |   51 +++++++
>  board/renesas/ap325rxa/ap325rxa.c      |  162 +++++++++++++++++++++
>  board/renesas/ap325rxa/config.mk       |   26 ++++
>  board/renesas/ap325rxa/cpld-ap325rxa.c |  206 +++++++++++++++++++++++++++
>  board/renesas/ap325rxa/lowlevel_init.S |  243 ++++++++++++++++++++++++++++++++
>  board/renesas/ap325rxa/u-boot.lds      |  105 ++++++++++++++
>  13 files changed, 794 insertions(+), 794 deletions(-)
>  delete mode 100644 board/ap325rxa/Makefile
>  delete mode 100644 board/ap325rxa/ap325rxa.c
>  delete mode 100644 board/ap325rxa/config.mk
>  delete mode 100644 board/ap325rxa/cpld-ap325rxa.c
>  delete mode 100644 board/ap325rxa/lowlevel_init.S
>  delete mode 100644 board/ap325rxa/u-boot.lds
>  create mode 100644 board/renesas/ap325rxa/Makefile
>  create mode 100644 board/renesas/ap325rxa/ap325rxa.c
>  create mode 100644 board/renesas/ap325rxa/config.mk
>  create mode 100644 board/renesas/ap325rxa/cpld-ap325rxa.c
>  create mode 100644 board/renesas/ap325rxa/lowlevel_init.S
>  create mode 100644 board/renesas/ap325rxa/u-boot.lds




More information about the U-Boot mailing list