[U-Boot] [PATCH 1/1] device: clone device on register

Wolfgang Denk wd at denx.de
Tue Sep 2 00:55:52 CEST 2008


Dear Jean-Christophe,

In message <20080901174820.432871d2 at hskinnemo-gx745.norway.atmel.com>
Haavard Skinnemoen wrote:
>
> > to prevent that the pointer will not be use for an other register
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> 
> Er. What? If a device is registered multiple times, that sounds like
> something which should be fixed, not papered over like this...
> 
> Btw, while I'm all for getting rid of common/lists.c, your cryptic
> one-line commit message is a shooting offense to anyone who tries to
> understand WTF is going on...

I agree with Haavard on both accounts.

Can you please look into this again? Thanks

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race is a race of cowards; and I am not  only  marching  in
that procession but carrying a banner.                   - Mark Twain


More information about the U-Boot mailing list