[U-Boot] [PATCH 1/1] device: clone device on register

Wolfgang Denk wd at denx.de
Tue Sep 2 01:02:07 CEST 2008


I wrote:

> > > to prevent that the pointer will not be use for an other register
> > > 
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > 
> > Er. What? If a device is registered multiple times, that sounds like
> > something which should be fixed, not papered over like this...
> > 
> > Btw, while I'm all for getting rid of common/lists.c, your cryptic
> > one-line commit message is a shooting offense to anyone who tries to
> > understand WTF is going on...
> 
> I agree with Haavard on both accounts.
> 
> Can you please look into this again? Thanks

OK, I learned that item (1) was actually a non-issue.

But can we please use a commit message that can be understood?
I cannot parse the current one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe, they said, depended for its operation on the balance of
four forces which they identified as charm,  persuasion,  uncertainty
and bloody-mindedness.      -- Terry Pratchett, "The Light Fantastic"


More information about the U-Boot mailing list