[U-Boot] [PATCH 1/1] ppc4xx: Add support for GPCS, SGMII and M88E1112 PHY

[Victor Gallardo]

Hi Ben,

OK. You are correct. I will update this area and resubmit.

-Victor Gallardo


-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com] 
Sent: Saturday, August 30, 2008 9:34 AM
To: Victor Gallardo
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 1/1] ppc4xx: Add support for GPCS, SGMII
and M88E1112 PHY

On Fri, Aug 29, 2008 at 11:20 PM, Victor Gallardo <vgallardo at amcc.com>
wrote:
> This patch adds GPCS, SGMII and M88E1112 PHY support for the AMCC 
> PPC460GT/EX processors.
>
> Signed-off-by: Victor Gallardo <vgallardo at amcc.com>
> ---
>  cpu/ppc4xx/4xx_enet.c |  116
++++++++++++++++++++++++++++++++++++++++++++++++-
>  cpu/ppc4xx/miiphy.c   |   40 ++++++++++++++++-
>  include/ppc4xx_enet.h |    4 ++
>  3 files changed, 155 insertions(+), 5 deletions(-)
>
> diff --git a/cpu/ppc4xx/4xx_enet.c b/cpu/ppc4xx/4xx_enet.c index 
> 8a38335..4729800 100644
> --- a/cpu/ppc4xx/4xx_enet.c
> +++ b/cpu/ppc4xx/4xx_enet.c
> @@ -198,6 +198,7 @@
>  #define BI_PHYMODE_RMII  8
>  #endif
>  #endif
> +#define BI_PHYMODE_SGMII 9
>
>  #if defined(CONFIG_440SP) || defined(CONFIG_440SPE) || \
>     defined(CONFIG_440EPX) || defined(CONFIG_440GRX) || \ @@ -216,6 
> +217,12 @@
>  #define MAL_RX_CHAN_MUL        1
>  #endif
>
> +#if !defined(CONFIG_PHY_LESS)
> +#define CONFIG_PHY_LESS        0xFFFFFFFF /* PHY-less mode */
> +#define CONFIG_PHY_LESS_SPEED  1000
> +#define CONFIG_PHY_LESS_DUPLEX FULL
> +#endif
> +
Sorry, but this is not scalable.  There are many real-world examples of
boards where one controller is connected to a PHY, and another has a
FIXED link to a switch or something else.  This driver is already an
unwieldy mess and adding this sort of thing only makes it worse.  If you
want to add fixed-link capabilities, please re-direct your efforts
towards a more generic, scalable solution.

regards,
Ben