[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

Markus Klotzbücher mk at denx.de
Tue Sep 9 15:50:37 CEST 2008


Dear Nicholas,

On Tue, Sep 09, 2008 at 10:13:47AM -0300, Nícolas Carneiro Lebedenco wrote:
> 
> Here it goes. I'm not sure if I got you right. Is it ok, now ?

Almost. 

> Signed-off-by: Nicolas Lebedenco <nicolas.lebedenco at tasksistemas.com.br>

This line should go _after_ the Changelog entry...

> It fixes the output of the command usb storage. It was printing  
> "Device 0: not available" because the IF_TYPE_USB was not included into the 
> switch statement.

and before the actual patch (namely here!)

> --- u-boot-1.3.4.original/disk/part.c	2008-08-12 11:08:38.000000000 -0300
> +++ u-boot-1.3.4/disk/part.c	2008-09-04 14:48:55.000000000 -0300
> @@ -124,6 +124,12 @@ void dev_print (block_dev_desc_t *dev_de
>  			dev_desc->revision,
>  			dev_desc->product);
>  		break;
> +	case IF_TYPE_USB:
> +		printf ("Vendor: %s Rev: %s Prod: %s\n",
> +			dev_desc->vendor,
> +			dev_desc->revision,
> +			dev_desc->product);
> +		break;
>  	case IF_TYPE_UNKNOWN:
>  	default:
>  		puts ("not available\n");

Sorry for beeing so pedantic, but could you fix this and resend once
more without context?  This is so we can use git-am to apply your
patch!

Obrigado!

Markus

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de")


More information about the U-Boot mailing list