[U-Boot] [PATCH 1/1] make MODEM SUPPORT generic instead of duplicate it

Wolfgang Denk wd at denx.de
Thu Apr 2 00:32:49 CEST 2009


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1236447277-18574-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  common/Makefile |    1 +
>  common/modem.c  |  123 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  lib_arm/board.c |   99 --------------------------------------------
>  lib_ppc/board.c |   97 -------------------------------------------
>  4 files changed, 124 insertions(+), 196 deletions(-)
>  create mode 100644 common/modem.c
...
> diff --git a/common/modem.c b/common/modem.c
> new file mode 100644
> index 0000000..27e164a
> --- /dev/null
> +++ b/common/modem.c
...
> +/* called from main loop (common/main.c) */
> +/* 'inline' - We have to do it fast */
> +static inline void mdm_readline(char *buf, int bufsiz)

How is this supposed to work? You cannot call a static function from
another source file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Don't worry about people stealing your ideas. If your ideas are  any
good, you'll have to ram them down people's throats."  - Howard Aiken


More information about the U-Boot mailing list