[U-Boot] [PATCH 1/1] make MODEM SUPPORT generic instead of duplicate it

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Sun Apr 5 10:56:01 CEST 2009


On 00:32 Thu 02 Apr     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1236447277-18574-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> >  common/Makefile |    1 +
> >  common/modem.c  |  123 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  lib_arm/board.c |   99 --------------------------------------------
> >  lib_ppc/board.c |   97 -------------------------------------------
> >  4 files changed, 124 insertions(+), 196 deletions(-)
> >  create mode 100644 common/modem.c
> ...
> > diff --git a/common/modem.c b/common/modem.c
> > new file mode 100644
> > index 0000000..27e164a
> > --- /dev/null
> > +++ b/common/modem.c
> ...
> > +/* called from main loop (common/main.c) */
> > +/* 'inline' - We have to do it fast */
> > +static inline void mdm_readline(char *buf, int bufsiz)
> 
> How is this supposed to work? You cannot call a static function from
> another source file.
this function is only use in this file

actualy the code is lib_arm/board.c and lib_ppc/board.c is identical

I just move it to modem.c

the only function use outiside of this file is mdm_init

Best Regards,
J.


More information about the U-Boot mailing list