[U-Boot] [PATCH] Macronix MX25xx MTD SPI flash driver

[Mike Frysinger]

On Monday 06 April 2009 03:23:30 Prafulla Wadaskar wrote:
> > > +		/* Up to 2 seconds */
> > > +		ret = macronix_wait_ready(flash, 2 * CONFIG_SYS_HZ);
> >
> > there's a common flash erase timeout define
>
> Block erase time for Micronix are different than specified in
> spi_flash_internals.h Hence MICRONIX spefic timouts defined and used in
> macronix.c

every flash will have a different erase time, but i have a hard time believing 
you picked 2*HZ (2 seconds) because of your part's requirements.  more likely 
you copied that from the stmicro driver (like every other spi flash driver 
until i cleaned them up).  the latest tree increases the common timeouts to 
seconds rather than milliseconds, so unless your flash is truly truly awful 
and requires longer than that, you should use the common define.

> I am ready with the updated patch,
> How should I release it the community?
> 1. new patch with review feedback (with same name)

the current accepted practice is for you to:
 - update the patch with all the comments
 - add a "v2" to the subject (so it'd be "[PATCH v2] Macronix .....")
 - in the comments section of the formatted patch (after the --- marker and 
above the diffstat), add notes about what changed in the updated patch
 - send it with the reply to header set to the last relevant message in the 
patches' thread

> 2. Delta on the top of previous patch

nooooooooo dont ever do this :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090406/be05af06/attachment.pgp