[U-Boot] [PATCH] Macronix MX25xx MTD SPI flash driver

[Prafulla Wadaskar]

> -----Original Message-----
> From: Mike Frysinger [mailto:vapier at gentoo.org] 
> Sent: Monday, April 06, 2009 1:09 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH] Macronix MX25xx MTD SPI flash driver
> 
> On Monday 06 April 2009 03:23:30 Prafulla Wadaskar wrote:
> > > > +		/* Up to 2 seconds */
> > > > +		ret = macronix_wait_ready(flash, 2 * 
> CONFIG_SYS_HZ);
> > >
> > > there's a common flash erase timeout define
> >
> > Block erase time for Micronix are different than specified in 
> > spi_flash_internals.h Hence MICRONIX spefic timouts defined 
> and used 
> > in macronix.c
> 
> every flash will have a different erase time, but i have a 
> hard time believing you picked 2*HZ (2 seconds) because of 
> your part's requirements.  more likely you copied that from 
> the stmicro driver (like every other spi flash driver until i 
> cleaned them up).  the latest tree increases the common 
> timeouts to seconds rather than milliseconds, so unless your 
> flash is truly truly awful and requires longer than that, you 
> should use the common define.
The MX25L12805D specifies Block erase max time to 2sec
Even sector erase time is higher (300milsec)
Specs can be found at (page 37) http://www.macronix.com/QuickPlace/hq/PageLibrary4825740B00298A3B.nsf/h_Index/7CE3021F57B8EA4848257412002E26CC/$File/MX25L12805D-1.1.pdf
 
> 
> > I am ready with the updated patch,
> > How should I release it the community?
> > 1. new patch with review feedback (with same name)
> 
> the current accepted practice is for you to:
>  - update the patch with all the comments
>  - add a "v2" to the subject (so it'd be "[PATCH v2] Macronix .....")
>  - in the comments section of the formatted patch (after the 
> --- marker and above the diffstat), add notes about what 
> changed in the updated patch
>  - send it with the reply to header set to the last relevant 
> message in the patches' thread
I will do the needful accordingly

> 
> > 2. Delta on the top of previous patch
> 
> nooooooooo dont ever do this :)
Thanks....
Stored in my mind
Regards..
Prafulla . .

> -mike
>