[U-Boot] Question about M29W128G CFI QRY bug

Stefan Roese sr at denx.de
Wed Apr 15 17:26:19 CEST 2009


On Wednesday 15 April 2009, Stefan Roese wrote:
> > > I don't like both versions. We should implement something which doesn't
> > > change the current behavior probably needed on some other boards. So
> > > how about something like this:
> >
> > I took your proposal and tried to implement it, hit a snag with
> > flash_write_cmd currently being a private function of cfi-flash.c
> > so, here is my 'counter-offer' pasted at the end of the message.
>
> Thanks. Looks good. I'll take it and prepare a proper patch.

Hmm. After looking a bit closer this doesn't seem to be this easy. I would 
like to add this function prototype to include/flash.h where other defines 
and function prototypes are collected right now. But this breaks some other 
boards implementing "their own" flash driver in their board directories, like 
AP1000, cpci5200, G2000, ppmc8260 and sbc405 (maintainers added to CC).

All those boards should be able to use the common CFI flash driver. I would 
really like to see those boards converted to this driver. It should be pretty 
easy. So maintainers from the boards mentioned above, if you need any help 
with this just let me know.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list