[U-Boot] [PATCH v2] Marvell MV88F6281GTW_GE Board support

Ben Warren biggerbadderben at gmail.com
Mon Apr 20 05:55:38 CEST 2009


Hi Prafulla,

Prafulla Wadaskar wrote:
<snip>
>>> +#define CONFIG_IPADDR		192.168.5.44
>>> +#define CONFIG_SERVERIP		192.168.5.30
>>> +#define CONFIG_NETMASK		255.255.255.0
>>>       
>> please remove the IP params
>>     
> Why ?
>
>   
Because these values are only relevant to your lab network, not anybody 
else who's going to use your boards. Boards should start with a clean 
slate. This is a hard rule that we've been enforcing for a while now - 
no address or network parameter initializations in config files.

regards,
Ben


More information about the U-Boot mailing list