[U-Boot] [PATCH] make fw_setenv write multiple variables

Wolfgang Denk wd at denx.de
Thu Apr 30 15:13:52 CEST 2009


Dear Marc,

In message <20090430113741.GD10108 at crichton.homelinux.org> you wrote:
> 
> If I didn't in the past, I did now; this is what we are using to write
> from the firmware to do bulk changes in the u-boot config space.
> 
> The patch is against 1.3.3

Thanks a lot.

Hm... this seems a lot of code to deal with a trivial issue. I  think
implementing  my  idea  (reading  the  input line by line from a text
file) would be much easier to implement and easier to use as well.

And of course the patch doesn't apply any more against current code.

[Not to mention that the Signed-off-by: line is missing, plus there
are coding style issues.]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made the integers; all else is the work of Man.       - Kronecker


More information about the U-Boot mailing list