[U-Boot] [PATCH] make fw_setenv write multiple variables

[Marc Leeman]

> Hm... this seems a lot of code to deal with a trivial issue. I  think
> implementing  my  idea  (reading  the  input line by line from a text
> file) would be much easier to implement and easier to use as well.

Yeah, probably.

IIRC, I tried to stick as close to the fw_Xenv code structure as possible;
as such, this basically copies the fw_setenv block and modifies it without
interfering or breaking in the upstream code.

> And of course the patch doesn't apply any more against current code.

I haven't looked at it, but unless there are large differences and rewrites
in fw_env.c; the block of code should apply pretty easily: that's one of the
underlying reasons keeping to current fw_env.c code separate and adding on it.

> [Not to mention that the Signed-off-by: line is missing, plus there
> are coding style issues.]

I didn't expect it to get applied: I just used it as input to the

fw_setenv key val val val val

example

-- 
br, marc

The best approach for you requires two steps. The first step is
reading the Manual.
    Wolfgang Denk - u-boot mailing list