[U-Boot] [PATCH] make fw_setenv write multiple variables

Wolfgang Denk wd at denx.de
Thu Apr 30 18:46:30 CEST 2009


Dear Marc Leeman,

In message <1f729c480904300627r5661774ej7d2cf5a19bee1083 at mail.gmail.com> you wrote:
> 
> IIRC, I tried to stick as close to the fw_Xenv code structure as possible;
> as such, this basically copies the fw_setenv block and modifies it without
> interfering or breaking in the upstream code.

Indeed. That code duplication is another problem, which for itself
would be reason enough to reject the patch.  It's unmaintainable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Men of peace usually are [brave].
	-- Spock, "The Savage Curtain", stardate 5906.5


More information about the U-Boot mailing list