[U-Boot] [PATCH] bmp_logo: Check return value of fread()

[Detlev Zundel]

Hi Mike,

>> I wasn't even thinking about language comments but simply names
>> especially in git-commit messages.
>
> i have no problem with localized names.  i do have a problem with localized 
> comments and source code.

Ok, so we're more or less in accord - remembering that names also show
up in git-logs and thus may force an encoding on the patches.

>> Obviously I'm lucky that I don't have an umlaut in my name, but if I
>> had, what would I do?
>
> currently, like every other person with an umlaut, you use an "e".  ö -> oe.

This was a solution of the 1900s, but I was under the impression, that
modern systems can cope with non-ascii characters, no?

>> Resort to latin-1?

I was unclear - what I meant was to use a "iso 8859-1" encoding without
explicitely stating it, i.e. that the > 0x7f byte is from 8859-1?

> presumably you mean ISO 8859-1, and in that case, that character set is the 
> same as in unicode (it was designed that way).

Well it may be at the same unicode position, but the encoding in byte
strings is still different of course.  The 8859-1 umlaut "ä" (= 0xe4 in
8859-1) is encoded as 0xce 0xa4 in utf-8 encoding which seems slightly
different.

>> What about French, Russian, etc. developers who want to see their "real"
>> name in the logs?
>
> get a new name !

Ah, the solution was so plain obvious all along :)

Cheers
  Detlev

-- 
C hasn't changed much since the 1970s. And let's face it it's ugly.
Can't we do better? C++? (Sorry, never mind.)
                                    -- Rob Pike
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de