[U-Boot] [PATCH] stx: add support for AMC8548 board

Peter Tyser ptyser at xes-inc.com
Tue Aug 4 16:53:46 CEST 2009


On Tue, 2009-08-04 at 14:27 +0200, Wolfgang Denk wrote:
> Dear oakad at yahoo.com,
> 
> In message <1249383697-28141-2-git-send-email-oakad at yahoo.com> you wrote:
> > From: Alex Dubov <oakad at yahoo.com>
> > 
> > STx AMC8548 board is an old, AMC form factor, MPC8548 based board intended
> > for RapidIO applications. It features 16MiB NAND flash, one DDR2 soDIMM
> > slot, ethernet on front panel and backplane, RapidIO on backplane, USB
> > controller on local bus (not currently enabled) and no PCI of any kind.
> > 
> > Signed-off-by: Alex Dubov <oakad at yahoo.com>
> > ---
> >  Makefile                          |    3 +
> >  board/stx/stxamc8548/Makefile     |   51 ++++++
> >  board/stx/stxamc8548/config.mk    |   32 ++++
> >  board/stx/stxamc8548/stxamc8548.c |  168 +++++++++++++++++++
> >  board/stx/stxamc8548/u-boot.lds   |  143 ++++++++++++++++
> >  include/configs/stxamc8548.h      |  332 +++++++++++++++++++++++++++++++++++++
> >  6 files changed, 729 insertions(+), 0 deletions(-)
> >  create mode 100644 board/stx/stxamc8548/Makefile
> >  create mode 100644 board/stx/stxamc8548/config.mk
> >  create mode 100644 board/stx/stxamc8548/stxamc8548.c
> >  create mode 100644 board/stx/stxamc8548/u-boot.lds
> >  create mode 100644 include/configs/stxamc8548.h
> 
> What's the difference between this patch and the previously submitted
> one:
> 
> 	Subject: [U-Boot] [PATCH 2/2] stx: add support for AMC8548 board
> 	From: Alex Dubov <oakad at yahoo.com>
> 	Date: Tue, 4 Aug 2009 02:26:49 -0700 (PDT)
> 
> ?

It looks like the MAINTAINERS and MAKEALL entries are still missing for
this board too FWIW.  Hopefully the other feedback has been taken into
consideration in this patch?

It'd be nice when you resubmitted patches to include "v2" in the title,
eg "[PATCH v2]" and also listed what you've changed in the comments
below your signed-off-by.  It makes it easier for others to keep track
of what the most recent patch is and what has changed between
resubmissions.

Best,
Peter



More information about the U-Boot mailing list