[U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

[Wolfgang Denk]

Dear Alex Dubov,

In message <21798.45018.qm at web37604.mail.mud.yahoo.com> you wrote:
> 
> > > --- a/board/stxgp3/Makefile
> > > +++ b/board/stx/common/Makefile
> > > @@ -1,5 +1,5 @@
> > >  #
> > > -# (C) Copyright 2001-2006
> > > +# (C) Copyright 2006
> > >  # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > 
> > How comes?
>
> Git is confused somehow.
> I don't see this change in my tree.

Well, the result looks wrong to me in any case.

...
> > Are you sure this is correct?
>
> Yes, this will cover all three boards affected by the change.
> They all have their address maps set in similar fashion.

Um... but that means you are actually changing the configuration for
some (or all?) of them?

How much of this were you able to test?

> > This looks fishy, too.
>
> Just look at the respective boards' law.c files before the patch.
> They all have this entry, either called CONFIG_SYS_LBC_OPTION_BASE or
> CONFIG_SYS_LBC_SDRAM_BASE.

I was referring to the whole block of code, not only the last entry.

> >     MAS3_SX|MAS3_SW|MAS3_SR, 0,
> > >           
> >     0, 0, BOOKE_PAGESZ_4K, 0),
> > 
> > Better split code beautifying into separate patch.
>
> I wrote this file from scratch.
> Git is confused here.

Hm... git notices high similarity of this file with existing code:

 rename board/{stxssa => stx/common}/tlb.c (59%)

> There's no separate patch.
> Same for the other issues here and below.

Maybe should do it as git sees it, then. Don't write new code or
change existing one unless necessary.

> > Hm... did you actually test these changes on all 4 boards?
>
> There are no real changes. All three boards have nearly identical configs.

Hmm.. PCI initialization and memory map looks a bit different now. Or
am I missing something?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
... The things love can drive a man to -- the  ecstasies,  the  mise-
ries,  the broken rules, the desperate chances, the glorious failures
and the glorious victories.
	-- McCoy, "Requiem for Methuselah", stardate 5843.7