[U-Boot] davinci_emac.c:*: warning: duplicate `volatile'

[ksi at koi8.net]

On Mon, 17 Aug 2009, Wolfgang Denk wrote:

> Dear ksi at koi8.net,
> 
> In message <Pine.LNX.4.64ksi.0908171053160.9943 at home-gw.koi8.net> you wrote:
> > 
> > what compiler do you use? I just compiled all the davinci boards with
> > GNUEABI GCC 4.4.1 (binutils ver.2.19.1) and I didn't get a single compiler
> > warning.
> 
> I was playing with old tool chains actually. That was with gcc 3.3.x.

Ah, that's ancient... I don't think we need to something for this. I betcha
it won't compile at all with something like 2.x.x but who cares? :)

> > There are 2 separate issues but they are not related to the above
> > description.
> > 
> > First is that it fails to compile with GNUEABI GCC but that is addressed in
> > your recent arm build patch that works OK.
> 
> Thanks for the confirmation! Much appreciated. Could you please send
> an Ack-by or Tested-by for that patch? Thanks in advance.

Sure I will.

> > The second one is that GCC 4.4.1 (don't know about the older ones, don't
> > have those on my machine now) generates an error for inline weak functions
> > in lib_arm/board.c (and I think it is totally correct -- what is an inline
> > weak function?) Here is the failed build log excertpt:
> 
> A patch for this has been posted some time ago. See
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65397/focus=65559
> 
> we're just waiting for the ARM custodian to take appropriate action.

OK.

> > As for those "duplicate `volatile'" warnings I don't see them (and have
> > never seen them before) so I don't know what to fix.
> > 
> > I can send you my build logs off the list if you want.
> 
> Well, here is an example - building davinci_schmoogie using ELDK 3.1.1
> (gcc version 3.3.3):
> 
> davinci_emac.c:82: warning: duplicate `volatile'
> davinci_emac.c:83: warning: duplicate `volatile'
> davinci_emac.c:84: warning: duplicate `volatile'
> davinci_emac.c:85: warning: duplicate `volatile'
> davinci_emac.c: In function `davinci_eth_open':
> davinci_emac.c:257: warning: duplicate `volatile'
> davinci_emac.c: In function `davinci_eth_rcv_packet':
> davinci_emac.c:475: warning: duplicate `volatile'
> davinci_emac.c:476: warning: duplicate `volatile'
> davinci_emac.c:477: warning: duplicate `volatile'
> davinci_emac.c:496: warning: duplicate `volatile'

Once again -- I don't think it requires any action. It builds without a
single warning with newer compilers, even with 4.2.x less for 4.4.1...

---
******************************************************************
*  KSI at home    KOI8 Net  < >  The impossible we do immediately.  *
*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
******************************************************************