[U-Boot] [PATCH] NAND: DaVinci: Adding 4 BIT ECC support

Wolfgang Denk wd at denx.de
Tue Aug 18 21:26:45 CEST 2009


Dear "Paulraj, Sandeep",

In message <0554BEF07D437848AF01B9C9B5F0BC5D7E99635F at dlee01.ent.ti.com> you wrote:
> 
> > What I mean is using accessors such as readl/writel -- though we're still
> > in a pretty sorry state with respect to what accessors we provide cross
> > architectures (you have to pick between native endian with no barriers,
> > or little endian with barriers).
> 
> Scott, I am quite certain that I have received comments for other patches that I have submitted earlier where I have been specifically been asked to do things the way I am doing at the moment and not use readl/writel(because of the reason you mentioned 
> above). 

Can you please use shorter lines? Something like a maximum lin leght
of 70 characters or so?  Thanks.

Well, this being a DaVinci driver, cross architectur poretability does
not really matter: this is ARM, and little-endian.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The bad reputation UNIX has gotten is totally undeserved, laid on by
people who don't understand, who have not gotten in there  and  tried
anything."          -- Jim Joyce, owner of Jim Joyce's UNIX Bookstore


More information about the U-Boot mailing list