[U-Boot] [PATCH 15/17] Move eNET low-level initialisation into asm

Wolfgang Denk wd at denx.de
Mon Aug 24 12:08:11 CEST 2009


Dear Graeme Russ,

In message <1250996401-13642-16-git-send-email-graeme.russ at gmail.com> you wrote:
>
> --- a/board/eNET/hardware.h
> +++ b/board/eNET/hardware.h
> @@ -32,4 +32,20 @@
>  #define LED_TX_BITMASK		0x10
>  #define LED_ERR_BITMASK		0x20
>  
> +/* Serial Port Definitions */
> +#define UART0_BASE 		0x3f8
> +
> +#define UART_RBR   		0x00
> +#define UART_THR   		0x00
> +#define UART_IER  		0x01
> +#define UART_IIR  		0x02
> +#define UART_FCR  		0x02
> +#define UART_LCR   		0x03
> +#define UART_MCR   		0x04
> +#define UART_LSR  		0x05
> +#define UART_MSR   		0x06
> +#define UART_SCR   		0x07
> +#define UART_DLL   		0x00
> +#define UART_DLM   		0x01

Please remove all SPACE characters that preceed TAB characters
(s/  *\t/\t/g)

> --- a/include/asm-i386/ic/sc520.h
> +++ b/include/asm-i386/ic/sc520.h
> @@ -1,6 +1,6 @@
>  /*
>   * (C) Copyright 2002
> - * Daniel Engström, Omicron Ceti AB <daniel at omicron.se>.
> + * Daniel Engstr�m, Omicron Ceti AB <daniel at omicron.se>.

Please do not mess umlauts.

>   * See file CREDITS for list of people who contributed to this
>   * project.
> @@ -134,7 +134,8 @@ typedef struct sc520_mmcr {
>  	u16 gptmr0cnt;		/* GP timer 0 count */
>  	u16 gptmr0maxcmpa;	/* GP timer 0 maxcount compare A */
>  	u16 gptmr0maxcmpb;	/* GP timer 0 maxcount compare B */
> -	u16 gptmr1ctl;		/* GP timer 1 mode/control */
> +	u16 gptmr1ctl;		/*#define SC520_SWTMRMILLI	0x
> +	 GP timer 1 mode/control */

Your patch is line wrapped or otherwise corrupted.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One friend in a lifetime is much; two  are  many;  three  are  hardly
possible. Friendship needs a certain parallelism of life, a community
of thought, a rivalry of aim.                     - Henry Brook Adams


More information about the U-Boot mailing list