[U-Boot] [PATCH v3][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API

Ben Warren biggerbadderben at gmail.com
Tue Aug 25 18:40:02 CEST 2009


Wolfgang,

Wolfgang Denk wrote:
> Dear Ben Warren,
>
> In message <4A9069E9.2030000 at gmail.com> you wrote:
>   
>>> Tested on mx31ads: works like a charm.
>>>   
>>>       
>> Great news!  Thanks!
>>     
>>> Will try to debug the trab issues later tonight (if I manage to find a
>>> matching JTAG connector for this board ).
>>>       
>
> OK, tested on trab (= SMDK2400), too. [The observed problems were
> caused by other, unrelated issues.]
>
>   
Great!
> You might want to consider adding this patch, though:
>
> From e1236c57d747c4b686f9918dba2333d4df539a54 Mon Sep 17 00:00:00 2001
> From: Wolfgang Denk <wd at denx.de>
> Date: Tue, 25 Aug 2009 11:55:16 +0200
> Subject: [PATCH] cs8900.c: Fix implicit integer to pointer conversion
>
> ---
>  drivers/net/cs8900.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c
> index b5555fe..587f7f6 100644
> --- a/drivers/net/cs8900.c
> +++ b/drivers/net/cs8900.c
> @@ -68,12 +68,13 @@ static u16 get_reg_init_bus(struct eth_device *dev, int regno)
>  	/* force 16 bit busmode */
>  	volatile u8 c;
>  	struct cs8900_priv *priv = (struct cs8900_priv *)(dev->priv);
> +	uint8_t volatile * const iob = (uint8_t volatile * const)dev->iobase;
>  
> -	c = readb(dev->iobase);
> -	c = readb(dev->iobase + 1);
> -	c = readb(dev->iobase);
> -	c = readb(dev->iobase + 1);
> -	c = readb(dev->iobase);
> +	c = readb(iob);
> +	c = readb(iob + 1);
> +	c = readb(iob);
> +	c = readb(iob + 1);
> +	c = readb(iob);
>  
>  	REG_WRITE(regno, &priv->regs->pptr);
>  	return REG_READ(&priv->regs->pdata);
>   
I'll add this and put this in the net/next branch.  Thanks for the help!

regards,
Ben


More information about the U-Boot mailing list