[U-Boot] [PATCH] [for next] i2c, ppc4xx: fix compiling KAREF and METROBOX boards.

[Stefan Roese]

Hi Heiko,

On Thursday 03 December 2009 11:23:17 Heiko Schocher wrote:
> commit eb5eb2b0f744f0cba405160c5d01335c40f09acf
> 
> ppc4xx: Cleanup PPC4xx I2C infrastructure
> 
> This patch cleans up the PPC4xx I2C intrastructure:
> 
> - Use C struct to describe the I2C registers instead of defines
> - Coding style cleanup (braces, whitespace, comments, line length)
> - Extract common code from i2c_read() and i2c_write()
> - Remove unneeded IIC defines from ppc405.h & ppc440.h
> 
> breaks comiling for the KAREF and METROBOX boards.
> 
> This patch fixes this issue.

Thanks for catching. Don't know why I missed those two boards.

But looking at the code (board/sandburst/common/ppc440gx_i2c.c), this seems to 
be a driver for the PPC4xx I2C bus 1. The common 4xx I2C driver 
(cpu/ppc4xx/i2c.c) is fully capable of handling I2C bus 0 *and* 1. Perhaps 
this was not the case when Travis wrote the board support. I would really like 
to drop this board specific code, as it doesn't seem necessary for me.

The board maintainer, Travis Sawyer, doesn't work for Sandburst (acquired by 
Broadcom some time ago?) any more. So we can't get his comments on this. Not 
sure what to do with those Sandburst boards now. They are not actively 
maintained any more. Perhaps we should remove them some time soon?

Wolfgang, what do you think? Should we try to carry such unmaintained boards 
on for ever?

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de