[U-Boot] [PATCH] [for next] i2c, ppc4xx: fix compiling KAREF and METROBOX boards.

[Heiko Schocher]

Hello Stefan,

Stefan Roese schrieb:
> On Thursday 03 December 2009 11:23:17 Heiko Schocher wrote:
>> commit eb5eb2b0f744f0cba405160c5d01335c40f09acf
>>
>> ppc4xx: Cleanup PPC4xx I2C infrastructure
>>
>> This patch cleans up the PPC4xx I2C intrastructure:
>>
>> - Use C struct to describe the I2C registers instead of defines
>> - Coding style cleanup (braces, whitespace, comments, line length)
>> - Extract common code from i2c_read() and i2c_write()
>> - Remove unneeded IIC defines from ppc405.h & ppc440.h
>>
>> breaks comiling for the KAREF and METROBOX boards.
>>
>> This patch fixes this issue.
> 
> Thanks for catching. Don't know why I missed those two boards.
> 
> But looking at the code (board/sandburst/common/ppc440gx_i2c.c), this seems to 
> be a driver for the PPC4xx I2C bus 1. The common 4xx I2C driver 
> (cpu/ppc4xx/i2c.c) is fully capable of handling I2C bus 0 *and* 1. Perhaps 
> this was not the case when Travis wrote the board support. I would really like 
> to drop this board specific code, as it doesn't seem necessary for me.

In the multibus_v2 approach I dropped it ;-)
I didn;t see any reasons for supporting this board specific i2c driver
any longer ...

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany