[U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c

Wolfgang Denk wd at denx.de
Fri Dec 4 22:45:49 CET 2009


Dear Heiko,

In message <4B175F3F.2060400 at denx.de> you wrote:
> 
> > Applied, thanks.
> > 
> > Heiko, I hope this is OK with you.
> 
> Hmm.. not really, my last comment on this was:

Ouch, sorry.

> http://lists.denx.de/pipermail/u-boot/2009-November/064245.html

I missed that, sorry. This was in another thread, not connected with
the patch.

> I don;t know, if this was ever used, but we should make this
> as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.

What do you suggest? Shall I revert the patch, or can you provide a
new commit to re-add this feature? [But then, it would be unused code,
which we don't want to add, right?]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Irrtum wiederholt sich immerfort in der Tat.  Deshalb muß man das
Wahre unermüdlich in Worten wiederholen.                     - Goethe


More information about the U-Boot mailing list