[U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
Heiko Schocher
hs at denx.de
Sat Dec 5 11:54:52 CET 2009
Hello Wolfgang,
Wolfgang Denk wrote:
> In message <4B175F3F.2060400 at denx.de> you wrote:
>>> Applied, thanks.
>>>
>>> Heiko, I hope this is OK with you.
>> Hmm.. not really, my last comment on this was:
>
> Ouch, sorry.
No probelm.
>> http://lists.denx.de/pipermail/u-boot/2009-November/064245.html
>
> I missed that, sorry. This was in another thread, not connected with
> the patch.
>
>> I don;t know, if this was ever used, but we should make this
>> as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.
>
> What do you suggest? Shall I revert the patch, or can you provide a
> new commit to re-add this feature? [But then, it would be unused code,
> which we don't want to add, right?]
I actually vote for removing the code, so I sent soon a patch, which
fixes the comment.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
More information about the U-Boot
mailing list