[U-Boot] [PATCH V2] ppc4xx: Canyonlands: Fix USB host PHY reset sequence

David Mitchell dmitchell at amcc.com
Mon Dec 14 22:33:56 CET 2009


Hi Wolfgang,

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Monday, December 14, 2009 3:16 PM
> To: David Mitchell
> Cc: u-boot at lists.denx.de; Stefan Roese; Jeff Mann
> Subject: Re: [U-Boot] [PATCH V2] ppc4xx: Canyonlands: Fix USB host PHY
> reset sequence
> 
> Dear Dave Mitchell,
> 
> In message <1260824693-11874-1-git-send-email-
> dmitchell at appliedmicro.com> you wrote:
> > Current de-assert reset is not sufficient for the USB PHY reset
> > on some Canyonlands platforms. The patch adds an assert/de-assert
> > sequence. This addresses a USB detection problem for devices
> > attached prior to power-up. The delay lengths are needed for
> > power to the PHY to stabilize.
> >
> > Signed-off-by: Jeff Mann <MannJ at embeddedplanet.com>
> > Signed-off-by: Dave Mitchell <dmitchell at appliedmicro.com>
> > Acked-by: Tirumala Reddy Marri <tmarri at appliedmicro.com>
> > ---
> > v1->v2: fixed typo
> 
> NAK again. This does not belong in generic board init code.

I see. Are you asking that all of the USB code be removed? Including the
previous PHY reset implementation done by the original Canyonlands port
(toggling the CPLD reset for the PHY).

Best regards,
-DM
--------------------------------------------------------

CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to AppliedMicro Corporation or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.


More information about the U-Boot mailing list