[U-Boot] [PATCH 3/3] Create configuration file for da850 EVM

[Wolfgang Denk]

Dear Sudhakar Rajashekhara,

In message <1260959070-29810-1-git-send-email-sudhakar.raj at ti.com> you wrote:
> Provides initial support for TI OMAP-L138/DA850 SoC devices
> on a Logic PD EVM board.
> 
> Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj at ti.com>
...
> diff --git a/Makefile b/Makefile
> index 769bf22..674dd1b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2933,6 +2933,11 @@ cp922_XA10_config	\
>  cp1026_config: unconfig
>  	@board/armltd/integrator/split_by_variant.sh cp $@
>  
> +da850evm_config:	unconfig
> +	@mkdir -p $(obj)include
> +	echo "#define CONFIG_DA850_EVM" >> $(obj)include/config.h

Please do not add such scripting to the top level Makefile; it is not
needed any more.

> --- /dev/null
> +++ b/include/configs/da850evm.h
...
> +/*
> + * U-Boot general configuration
> + */
> +#undef CONFIG_USE_IRQ			/* No IRQ/FIQ in U-Boot */
> +#undef CONFIG_MISC_INIT_R
> +#undef CONFIG_BOOTDELAY

Don't undef what is not defined.

> +#define CONFIG_BOOTFILE		"uImage" /* Boot file name */
> +#define CONFIG_SYS_PROMPT	"DA850-evm > " /* Command Prompt */
> +#define CONFIG_SYS_CBSIZE	1024 /* Console I/O Buffer Size	*/
> +#define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> +#define CONFIG_SYS_MAXARGS	16 /* max number of command args */
> +#define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE /* Boot Args Buffer Size */
> +#define CONFIG_SYS_LOAD_ADDR	(CONFIG_SYS_MEMTEST_START + 0x700000)
> +#define CONFIG_VERSION_VARIABLE
> +#define CONFIG_AUTO_COMPLETE	/* Won't work with hush so far, may be later */

Why does this not work?


> +/*
> + * Linux Information
> + */
> +#define LINUX_BOOT_PARAM_ADDR	(CONFIG_SYS_MEMTEST_START + 0x100)
> +#define CONFIG_CMDLINE_TAG
> +#define CONFIG_SETUP_MEMORY_TAGS
> +#define CONFIG_BOOTARGS		"mem=32M console=ttyS2,115200n8 root=/dev/mtdblock/2 rw noinitrd ip=dhcp"

Line too long!

> +#define CONFIG_BOOTCOMMAND	""

What do you intend here? If you don't need a boot command, then don't
define one. Defining an empty one makes no sense.

...
> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_SAVES
> +#define CONFIG_CMD_MEMORY
> +#undef CONFIG_CMD_FPGA
> +#undef CONFIG_CMD_SETGETDCR

Don't undef what is not defined. [Fix globally.]

> +#define CONFIG_ENV_IS_NOWHERE
> +#define CONFIG_SYS_NO_FLASH
> +#define CONFIG_ENV_SIZE		(16 << 10)
> +#undef CONFIG_CMD_IMLS

Why would you undefine this command? "imls" is a pretty useful
command, and does not require a substantioal amount of memory?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"IBM uses what I like to call the 'hole-in-the-ground  technique'  to
destroy  the  competition.....  IBM digs a big HOLE in the ground and
covers it with leaves. It then puts a big POT OF GOLD nearby. Then it
gives the call, 'Hey, look at all this gold, get over here fast.'  As
soon  as  the competitor approaches the pot, he falls into the pit"
                                                     - John C. Dvorak