[U-Boot] [PATCH 3/3] Create configuration file for da850 EVM

[Sudhakar Rajashekhara]

Hi,

Wolfgang Denk <wd <at> denx.de> writes:

> 
> Please do not add such scripting to the top level Makefile; it is not
> needed any more.
> 

OK. I'll remove it.

> > --- /dev/null
> > +++ b/include/configs/da850evm.h
> ...
> > +/*
> > + * U-Boot general configuration
> > + */
> > +#undef CONFIG_USE_IRQ			/* No IRQ/FIQ in U-Boot */
> > +#undef CONFIG_MISC_INIT_R
> > +#undef CONFIG_BOOTDELAY
> 
> Don't undef what is not defined.
> 

OK. Will fix it globally.

[...]

> > +#define CONFIG_BOOTARGS		"mem=32M console=ttyS2,115200n8 
root=/dev/mtdblock/2 rw noinitrd ip=dhcp"
> 
> Line too long!
> 

I'll correct it.

> > +#define CONFIG_BOOTCOMMAND	""
> 
> What do you intend here? If you don't need a boot command, then don't
> define one. Defining an empty one makes no sense.
> 

I'll remove it.

[...]

> > +#undef CONFIG_CMD_IMLS
> 
> Why would you undefine this command? "imls" is a pretty useful
> command, and does not require a substantioal amount of memory?
> 

I'll enable support for "imls" once I add in support for SPI/NAND/NOR flashes.

Regards,
Sudhakar