[U-Boot] [PATCH] add ASTRO MCF5373L board

Wolfgang Denk wd at denx.de
Fri Dec 18 21:07:59 CET 2009


Dear Wolfgang Wegner,

In message <20091218142428.GD30882 at leila.ping.de> you wrote:
> 
> > >  TASREG_config :		unconfig
> > >  	@$(MKCONFIG) $(@:_config=) m68k mcf52x2 tasreg esd
> > >  
> > > +astro_mcf5373l_config \
> > > +astro_mcf5373l_ram_config :	unconfig
> > > +	@if [ "$@" = "astro_mcf5373l_ram_config" ] ; then \
> > > +		echo "#define CONFIG_MONITOR_IS_IN_RAM"	>> $(obj)include/config.h ; \
> > > +		echo "TEXT_BASE = 0x40020000" > $(obj)board/astro/mcf5373l/config.tmp ; \
> > > +		$(XECHO) "... for RAM boot ..." ; \
> > > +	else \
> > > +		echo "TEXT_BASE = 0x00000000" > $(obj)board/astro/mcf5373l/config.tmp ; \
> > > +		$(XECHO) "... for FLASH boot ..." ; \
> > > +	fi
> > > +	@$(MKCONFIG) -a astro_mcf5373l m68k mcf532x mcf5373l astro
> > 
> > Please keep lists sorted, and don't add such scripting to the
> > Makefile. It is not needed any more.
> 
> Another question here:
> which sorting scheme should I adhere to? With the exception of the
> tasreg board, all coldfire boards are sorted according to their
> processor number (this sorting is in turn alphabetical, not numerical,
> probably because it better represents the family affiliation), only
> the tasreg board is at the end of the list according to the
> alphabetical order of the board names...

Please use the equivalent of "sort -f" on the make target names.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Deliver yesterday, code today, think tomorrow."


More information about the U-Boot mailing list