[U-Boot] [PATCH] add ASTRO MCF5373L board

Wolfgang Wegner wolfgang at leila.ping.de
Fri Dec 18 15:24:28 CET 2009


Dear Wolfgang Denk,

On Thu, Dec 17, 2009 at 11:33:07PM +0100, Wolfgang Denk wrote:
> Dear Wolfgang Wegner,
> 
[...]
> > diff --git a/Makefile b/Makefile
> > index 75b2c1e..924e210 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2263,6 +2263,18 @@ M5485HFE_config :	unconfig
> >  TASREG_config :		unconfig
> >  	@$(MKCONFIG) $(@:_config=) m68k mcf52x2 tasreg esd
> >  
> > +astro_mcf5373l_config \
> > +astro_mcf5373l_ram_config :	unconfig
> > +	@if [ "$@" = "astro_mcf5373l_ram_config" ] ; then \
> > +		echo "#define CONFIG_MONITOR_IS_IN_RAM"	>> $(obj)include/config.h ; \
> > +		echo "TEXT_BASE = 0x40020000" > $(obj)board/astro/mcf5373l/config.tmp ; \
> > +		$(XECHO) "... for RAM boot ..." ; \
> > +	else \
> > +		echo "TEXT_BASE = 0x00000000" > $(obj)board/astro/mcf5373l/config.tmp ; \
> > +		$(XECHO) "... for FLASH boot ..." ; \
> > +	fi
> > +	@$(MKCONFIG) -a astro_mcf5373l m68k mcf532x mcf5373l astro
> 
> Please keep lists sorted, and don't add such scripting to the
> Makefile. It is not needed any more.

Another question here:
which sorting scheme should I adhere to? With the exception of the
tasreg board, all coldfire boards are sorted according to their
processor number (this sorting is in turn alphabetical, not numerical,
probably because it better represents the family affiliation), only
the tasreg board is at the end of the list according to the
alphabetical order of the board names...

Best regards,
Wolfgang



More information about the U-Boot mailing list