[U-Boot] [PATCH] add ASTRO MCF5373L board

[Wolfgang Denk]

Dear Wolfgang Wegner,

In message <20091217235204.GB30882 at leila.ping.de> you wrote:
> 
> > Please keep lists sorted, and don't add such scripting to the
> > Makefile. It is not needed any more.
> 
> How can I avoid this scripting? I took the freescale EVM boards as a
> reference. Could you please point me to a better example on how to
> set these variables, especially TEXT_BASE, on a per-target basis?

The new "mkconfig" script allows you to generate CONFIG_MK_* variables
from the make target names, which you then can use to adjust other
settings.

> > > +	/* PAR_T0IN -> GPIO */
> > > +	gpiop->par_timer &= 0xfc;
> > 
> > Please use I/O accessors to access device registers. Please fix
> > globally.
> 
> Sorry if this is a stupid question, but so this should read:
> 
> tmp_char = readb(&gpiop->par_timer);
> tmp_char &= 0xfc;
> writeb(tmp_char, &gpiop->par_timer);

Right.

> And how about word and long-word registers? As far as I understand
> from asm-m68k/io.h, the I/O accessors do byte-swap, how does this
> make sense on a big-endian-only device?

There should be non-swapping accessor functions as well.

> > Do you really need a board specific linker script?
> 
> Probably not in this case, but unfortunately this is what all
> current Coldfire boards do, and I am not familiar enough with
> ld to overlook which consequences changing this might have.

Hm...

Tsi Chung Liew, are you planning for some cleanup to use a single
common linker script for all boards without special requirements?

> (It may be trivial for MCF53xx, but for other devices like
> MCF5445x with the possibility for serial boot, there are
> big differences between the different linker files.)

There are probably just a few major "types" ?

> > > +		s = flash_full_status_check_nb (flash_info, fl_sector,
> > > +						0, "erase");
> > > +		if (s != ERR_BUSY) {
> > > +			if (s == ERR_OK) {
> > > +				flash_sect_count++;
> > > +				flash_prog_stat = FL_STAT_IDLE;
> > > +			}
> > > +			else
> > 
> > And again. Please fix indentation globally.
> 
> Sorry to ask, but which part of indentation is wrong here?
> (Except the else/if you quoted in the other examples)

the "else" must be on the same line as the "}".

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I see that Microsoft's campaign  to  destroy  all  knowledge  of  any
operating   environment   but  its  own  environment-of-the-year  has
succeeded in creating a generation of users who don't understand  the
concept of a shell...
            -- L. Peter Deutsch in <m0x5jNX-000R2UC at lamp.aladdin.com>